Tidy 1 #240
Merged
Tidy 1 #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junghao
requested review from
CallumNZ and
wilsonjord
and removed request for
CallumNZ
wilsonjord
reviewed
Aug 14, 2023
wilsonjord
previously approved these changes
Aug 14, 2023
sue-h-gns
dismissed
wilsonjord’s stale review
The merge-base changed after approval.
wilsonjord
previously approved these changes
Aug 15, 2023
junghao
dismissed
wilsonjord’s stale review
The merge-base changed after approval.
wilsonjord
requested changes
Aug 15, 2023
| @@ -39,8 +39,6 @@ for i in "$@"; do | |||
|
|
|||
| docker build \ | |||
| --build-arg=BUILD="$i" \ | |||
| --build-arg=RUNNER_IMAGE="$RUNNER_IMAGE" \ | |||
| --build-arg=BUILDER_IMAGE="$BUILDER_IMAGE" \ | |||
There was a problem hiding this comment.
suggestion: should the above lines also be removed?
# code will be compiled in this container
BUILDER_IMAGE='quay.io/geonet/golang:1.16-alpine'
RUNNER_IMAGE='quay.io/geonet/go-scratch:latest'
wilsonjord
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build and runner image parameters specified in build.sh don't fit with new Dockerfile's base image. Removing.